Skip to content

chore: bump deps to latest and prep with ibc-go v11#1065

Open
aljo242 wants to merge 11 commits intomainfrom
feat/ibc-go-v11-local
Open

chore: bump deps to latest and prep with ibc-go v11#1065
aljo242 wants to merge 11 commits intomainfrom
feat/ibc-go-v11-local

Conversation

@aljo242
Copy link
Contributor

@aljo242 aljo242 commented Mar 10, 2026

No description provided.

aljo242 added 7 commits March 6, 2026 11:05
- Replace ibc-go/v10 imports with ibc-go/v11 across evm, evmd, and tests
- Add replace directive for ../ibc-go in go.mod for local development
- Update IBC interfaces, precompiles, and test utilities for v11 compatibility

Made-with: Cursor
Cancel functions are returned to callers for subscription cleanup.
Also update go.mod/go.sum for dependency sync.

Made-with: Cursor
@greptile-apps
Copy link

greptile-apps bot commented Mar 10, 2026

Greptile Summary

This PR is a routine dependency bump that migrates the entire cosmos/evm codebase from ibc-go v10 to v11, along with several smaller version upgrades (Go 1.25.7→1.25.8, cosmos-sdk prerelease, grpc v1.79.1→v1.79.2, RoaringBitmap v2.14.4→v2.14.5). All 74 changed files are updated consistently — the vast majority are purely import-path substitutions of ibc-go/v10ibc-go/v11 with no logic changes.

Key points:

  • ibc-go v10 → v11: All import paths, keeper references, testing helpers, and middleware wiring are updated uniformly across production code and tests.
  • tests/systemtests/go.mod: The previously required replace directive pinning ibc-go/v10 to an older commit (used as a workaround for an old groups module path issue) is correctly removed now that v11 is in use. The indirect dependencies cosmossdk.io/x/tx v1.2.0-rc.1 and cosmossdk.io/x/upgrade v0.2.0 that were pinned alongside it are also dropped.
  • rpc/websockets.go: Three context.WithCancel(context.Background()) calls gain //nolint:gosec comments. The inline label G118 used in the explanation does not correspond to a documented standard gosec rule number — this is cosmetically inaccurate but does not affect runtime behavior or lint suppression.
  • No functional or business-logic changes are present in this PR.

Confidence Score: 5/5

  • This PR is safe to merge — it is a systematic, mechanical migration with no logic changes.
  • All 74 files contain only import-path substitutions (v10→v11) and minor version bumps in go.mod files. No business logic, state machine, or security-sensitive code paths were altered. The removal of the systemtests workaround replace directive is a clean-up that is now appropriate. The only non-trivial observation is a cosmetically inaccurate gosec rule number in nolint comments, which has no runtime or lint-correctness impact.
  • No files require special attention beyond the minor nolint comment inaccuracy in rpc/websockets.go.

Important Files Changed

Filename Overview
go.mod Root go.mod bumps ibc-go v10→v11, cosmos-sdk, grpc v1.79.1→v1.79.2, Go 1.25.7→1.25.8, and RoaringBitmap v2.14.4→v2.14.5; no logic changes.
evmd/go.mod Mirrors root go.mod bump: ibc-go v10→v11, cosmos-sdk, grpc, Go, and RoaringBitmap version upgrades.
tests/systemtests/go.mod ibc-go v10→v11, cosmos-sdk bump, Go 1.25.8, removes the old v10 replace workaround (and its comment) and drops indirect deps cosmossdk.io/x/tx v1.2.0-rc.1 and cosmossdk.io/x/upgrade v0.2.0 that were previously pinned because of the v10 path issue.
tests/speedtest/go.mod ibc-go indirect dep upgraded from v10→v11, cosmos-sdk and grpc bumped, Go 1.25.8.
rpc/websockets.go Adds three //nolint:gosec // G118: cancel returned to caller for subscription cleanup comments on context.WithCancel lines; G118 is not a standard gosec rule number, making the inline explanation slightly misleading but functionally harmless.
x/ibc/callbacks/keeper/keeper.go Pure import path migration from ibc-go/v10 to ibc-go/v11; no logic changes.
x/erc20/v2/ibc_middleware.go Pure import path migration from ibc-go/v10 to ibc-go/v11; no logic changes.
evmd/app.go All 14 ibc-go import paths updated from v10 to v11; no logic or wiring changes.
precompiles/ics20/tx.go Pure import path migration from ibc-go/v10 to ibc-go/v11; no logic changes.
precompiles/ics02/tx.go Pure import path migration from ibc-go/v10 to ibc-go/v11; no logic changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[cosmos/evm root module] -->|ibc-go v11| B[ibc-go/v11/modules/core]
    A -->|ibc-go v11| C[ibc-go/v11/modules/apps/transfer]
    A -->|ibc-go v11| D[ibc-go/v11/modules/apps/callbacks]
    A -->|ibc-go v11| E[ibc-go/v11/testing]

    B --> F[ante/\nibc_middleware]
    B --> G[precompiles/ics02\nprecompiles/ics20]
    B --> H[x/erc20/ibc_middleware\nx/erc20/v2/ibc_middleware]
    B --> I[x/ibc/callbacks/keeper]

    C --> G
    C --> H
    C --> I

    D --> I

    E --> J[testutil/ibc/\nevmd/tests/ibc/]

    subgraph go.mod files updated
        K[go.mod]
        L[evmd/go.mod]
        M[tests/speedtest/go.mod]
        N[tests/systemtests/go.mod\n- removed v10 replace workaround]
    end
Loading

Last reviewed commit: d5e238c

aljo242 and others added 2 commits March 10, 2026 15:27
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
- Restore missing func (api *pubSubAPI) subscribeNewHeads declaration
- Remove duplicate ctx,cancel line from bad merge
- Use #nosec G118 instead of nolint:gosec (avoids nolintlint)

Made-with: Cursor
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.14%. Comparing base (bea1ab9) to head (f53594d).

Files with missing lines Patch % Lines
rpc/websockets.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1065      +/-   ##
==========================================
+ Coverage   64.11%   64.14%   +0.02%     
==========================================
  Files         331      331              
  Lines       23303    23303              
==========================================
+ Hits        14941    14947       +6     
+ Misses       6946     6940       -6     
  Partials     1416     1416              
Files with missing lines Coverage Δ
ante/ante.go 81.25% <ø> (ø)
ante/cosmos.go 100.00% <ø> (ø)
ibc/module.go 92.85% <ø> (ø)
ibc/utils.go 100.00% <ø> (ø)
precompiles/ics02/tx.go 46.66% <ø> (ø)
precompiles/ics02/types.go 40.74% <ø> (ø)
precompiles/ics20/query.go 92.85% <ø> (ø)
precompiles/ics20/tx.go 71.31% <ø> (ø)
precompiles/ics20/types.go 71.42% <ø> (ø)
precompiles/types/defaults.go 66.66% <ø> (ø)
... and 11 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@vladjdk vladjdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ conflicts fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants